dschlieder
Well Known Member
Anyone out there have any good solutions for cleaning up the code that is flagged as "// Following ER merged in B733 upgrade" after applying an ESU?
I just spent the better part of a day re-applying our custom modifications to P4210. We did a merge the last two times we applied an ESU as it is easier and faster and less prone to error to retrofit custom code that was merged then to attempt to type it in.
I have very detailed documentation of our modifications and using that as a guide, I located all of our custom code that was commented out at the bottom of the ER, copied and pasted it where I needed it, verified it and then deleted all of the merged code at the bottom of those sections. (I have found you need to carefully do this. Selecting too much or from the top to the bottom or ??? when you press the little cute trashcan, Form Designer crashes with a memory error. So you need to save and save often and know exactaly where you where the last time you saved. But P4210 doesn't save very fast.)
However, in redoing my documentation for the next go around, I found a number of sections that we did not have any custom code in them that had "// Following ER merged in B733 upgrade" and hundreds of lines of ER after that comment. In some cases, the merged commented code was in there twice, once from the previous ESU and once from the current one we applied.
So I decided to clean that up as it takes too long to check this application in and transfer it to other environments as it is and hoped this would make it easier for those tasks.
So off I went deleting code. All was well till I got to one hyper item. There were a number of commented out but orphaned END IFs and END WHILEs in that area. When I deleted a commented out end if, the first ACTIVE if in the ER was deleted! Then I couldn't save because there was an orphaned active END IF for the IF that was deleted! And of course the code was toast at that point as it deleted code it should not have.
So I deleted nothing but comments and variable assignments, etc. leaving the commented out orphaned END IFs and END WHILEs alone. Good, now I could save the ER. BUT when I went to save the application the validation failed on other UNRELATED parts of the ER! So that wasn't going to work.
Now I am concerned that the code I did delete where we had our custom modifications MAY have done something flaky to the code in those sections. I have no idea what active code above the "// Following ER merged in B733 upgrade" line may have been deleted when I was deleting code below that line.
I have also seen many times in the past where what you see in the ER is not what is actually being executed. I have seen code that appears as "If x = 1", but bringing up the if editor, it will actually be executing "If x = 2"! I started an issue with that one but I don't think JDE believe me.
Any thoughts anyone?
Thanks,
Dave
B7332 SP 15 with some one offs AS/400
I just spent the better part of a day re-applying our custom modifications to P4210. We did a merge the last two times we applied an ESU as it is easier and faster and less prone to error to retrofit custom code that was merged then to attempt to type it in.
I have very detailed documentation of our modifications and using that as a guide, I located all of our custom code that was commented out at the bottom of the ER, copied and pasted it where I needed it, verified it and then deleted all of the merged code at the bottom of those sections. (I have found you need to carefully do this. Selecting too much or from the top to the bottom or ??? when you press the little cute trashcan, Form Designer crashes with a memory error. So you need to save and save often and know exactaly where you where the last time you saved. But P4210 doesn't save very fast.)
However, in redoing my documentation for the next go around, I found a number of sections that we did not have any custom code in them that had "// Following ER merged in B733 upgrade" and hundreds of lines of ER after that comment. In some cases, the merged commented code was in there twice, once from the previous ESU and once from the current one we applied.
So I decided to clean that up as it takes too long to check this application in and transfer it to other environments as it is and hoped this would make it easier for those tasks.
So off I went deleting code. All was well till I got to one hyper item. There were a number of commented out but orphaned END IFs and END WHILEs in that area. When I deleted a commented out end if, the first ACTIVE if in the ER was deleted! Then I couldn't save because there was an orphaned active END IF for the IF that was deleted! And of course the code was toast at that point as it deleted code it should not have.
So I deleted nothing but comments and variable assignments, etc. leaving the commented out orphaned END IFs and END WHILEs alone. Good, now I could save the ER. BUT when I went to save the application the validation failed on other UNRELATED parts of the ER! So that wasn't going to work.
Now I am concerned that the code I did delete where we had our custom modifications MAY have done something flaky to the code in those sections. I have no idea what active code above the "// Following ER merged in B733 upgrade" line may have been deleted when I was deleting code below that line.
I have also seen many times in the past where what you see in the ER is not what is actually being executed. I have seen code that appears as "If x = 1", but bringing up the if editor, it will actually be executing "If x = 2"! I started an issue with that one but I don't think JDE believe me.
Any thoughts anyone?
Thanks,
Dave
B7332 SP 15 with some one offs AS/400